Skip to content

VHDS: implementation of on-demand RDS updates#6406

Closed
dmitri-d wants to merge 1 commit intoenvoyproxy:masterfrom
dmitri-d:vhds
Closed

VHDS: implementation of on-demand RDS updates#6406
dmitri-d wants to merge 1 commit intoenvoyproxy:masterfrom
dmitri-d:vhds

Conversation

@dmitri-d
Copy link
Contributor

@dmitri-d dmitri-d commented Mar 27, 2019

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@dmitri-d
Copy link
Contributor Author

dmitri-d commented Mar 27, 2019

@htuch: first working iteration of on-demand RDS updates.

@lizan lizan requested a review from htuch March 28, 2019 00:13
@dmitri-d
Copy link
Contributor Author

dmitri-d commented Mar 28, 2019

Also @brian-avery.

@htuch
Copy link
Member

htuch commented Mar 29, 2019

@dmitri-d walked us through this today at our sync up and overall the plan for VHDS looks solid to me. There are some outstanding issues around the right way to coordinate request holding and some race conditions that might lead to a client nonce being introduced.

Next steps are to break this down into some finer grained patches, #6418 is the first. We'll be doing reviews in this PRs but maintain this draft PR as reference for the big picture.

@htuch htuch added the waiting label Mar 29, 2019
htuch
htuch reviewed Apr 3, 2019
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge master to pick up #6418 now that it's merged? Ta.

@dmitri-d
Copy link
Contributor Author

dmitri-d commented Apr 3, 2019

  • rebased

@htuch htuch added the waiting label Apr 4, 2019
@stale
Copy link

stale bot commented Apr 10, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 10, 2019
@stale
Copy link

stale bot commented Apr 17, 2019

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Apr 17, 2019
@htuch htuch added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Apr 17, 2019
@htuch htuch reopened this Apr 17, 2019
@mattklein123 mattklein123 removed no stalebot Disables stalebot from closing an issue labels Jun 18, 2019
@stale
Copy link

stale bot commented Jun 26, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 26, 2019
@stale
Copy link

stale bot commented Jul 3, 2019

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Jul 3, 2019
@dmitri-d dmitri-d deleted the vhds branch May 20, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@htuch htuch htuch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@htuch htuch

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmitri-d @htuch @mattklein123